Skip to content

Build against unitsml-rs cdfbcc3 and replay the Ruby point/difference cases - #5

Merged
suleman-uzair merged 1 commit into
mainfrom
feat/difference-point-parity-20261112
Nov 12, 2026
Merged

suleman-uzair merged 1 commit into
mainfrom
feat/difference-point-parity-20261112

Conversation

@suleman-uzair

Copy link
Copy Markdown
Member

This PR moves the native pin in native-source.json and ci/native-source.json from unitsml/unitsml-rs 14c1707 to main cdfbcc3. That brings in two point/difference fixes that match unitsml-ruby:

Cargo.lock is unchanged (sha256 949a6198…), and so are the unitsdb-rs, asciiunits-python 9a405a5 (Parsanol 5206a33) and F40 corpus pins.

Changes

  • native-source.json: native source cdfbcc3. The fallback library hash is a local 1.95.0 build; CI still validates the binary it builds through the build receipt.
  • tests/point-difference-vectors.json holds the 24 point/difference add and subtract cases recorded from unitsml-ruby 2ec9583. They cover degC and K operands with point and difference scale on each side.
  • tests/test_point_difference.py checks that the installed wheel returns, for each case, the same exact magnitude, unit and scale as Ruby.
  • tests/test_dependency_pins.py expects the unitsml native build from cdfbcc3.

… cases

unitsml-rs main cdfbcc3 adds two point/difference fixes that match
unitsml-ruby: a difference minus an absolute point is a difference
(85a4485, unitsml/unitsml-rs#3), and a difference plus a point answers in
the difference's unit (cdfbcc3, unitsml/unitsml-rs#4). Cargo.lock is
unchanged since 4aa5f3f; the unitsdb-rs, asciiunits-python 9a405a5 and F40
corpus pins are unchanged.

tests/point-difference-vectors.json holds the 24 point/difference add and
subtract cases from unitsml-ruby 2ec9583. tests/test_point_difference.py
checks each case's exact magnitude, unit and scale against the installed
wheel.
@suleman-uzair
suleman-uzair marked this pull request as ready for review November 12, 2026 15:43
@suleman-uzair
suleman-uzair merged commit 4ace356 into main Nov 12, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant