Repository navigation
Build against the final unitsml-rs delivery and replay the register scope vectors - #3
Merged
Merged
Conversation
…cope vectors The native pin moves from unitsml-rs fd3b3cb to 14c1707, which includes 87c97eb: a caller registration applies only to the unit the request names. unitsml-rs now takes unitsdb-rs 969a131 (UnitsDB b210137, merged as b0b4315) as a locked Cargo git dependency, so the sibling unitsdb-rs checkout is dropped. native-source.json records the new commit, Cargo.lock, UnitsDB data and library hashes; CI still validates the binary it builds through the build receipt. The asciiunits and F40 corpus pins are unchanged. tests/register-scope-vectors.json records two vectors from unitsml-ruby 2ec9583 on UnitsDB b0b4315: with the pound (NISTu201) registered, 2 lb converts to 45359237/50000000 kg, and cwt (US) (NISTu230) is refused because the pound has no UnitsDB conversion. tests/test_register_scope.py replays them against the installed wheel; the F40 vectors are unchanged.
suleman-uzair
marked this pull request as ready for review
November 12, 2026 13:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the native pin in
native-source.jsonandci/native-source.jsonfromunitsml/unitsml-rsfd3b3cb to the final delivery head 14c1707. That head includes 87c97eb: a caller registration now applies only to the unit the request names. Registering the pound no longer makes the US hundredweight convertible.Changes
native-source.json: native source 14c1707, itsCargo.lockhash,unitsdb-rs969a131 with its bundled UnitsDB b210137 data hash, and the library hash of a local 1.95.0 build. CI still validates the binary it builds through the build receipt.ci/native-source.json:unitsdb-rsis now a locked Cargo git dependency ofunitsml-rs, so the sibling checkout (checkout_as) is gone. The asciiunits and F40 corpus pins are unchanged.tests/register-scope-vectors.jsonholds two new vectors recorded from unitsml-ruby 2ec9583 on UnitsDB b0b4315. Registeringlb(NISTu201) converts 2 lb to 45359237/50000000 kg. With only the pound registered,cwt (US)(NISTu230) is refused with aConversionError; the native code ismissing_conversion.tests/test_register_scope.pyreplays those vectors against the installed wheel.tests/f40-quantities.jsonandtests/test_installed.pyare unchanged.