Repository navigation
Conversation
grep_search walked and read every file under its root, including .git, node_modules and target. glob_search already prunes these directories (ultraworkers#2986), and docs/g002-security-verification-map.md says both search tools do. In a Rust checkout with a 2.5 GB target/ directory, one grep_search call took about 2.3 s instead of about 0.13 s, with the same results. Use the same pruning for grep_search, and never prune the search root itself, so a search the caller points into node_modules or target still works for both tools.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grep_searchwalks and reads every file under its root, including.git,node_modulesandtarget.glob_searchalready prunes these directories (runtime: prune heavy directories during glob searches #2986), anddocs/g002-security-verification-map.mdsays both search tools do.grep_searchcall spends nearly all its time readingtarget/.grep_searchnow uses the same pruning asglob_search. The search root itself is never pruned, so a search the caller points intonode_modulesortargetstill works. That also fixesglob_search, which currently returns nothing when its walk root is one of these directories.Measured on Windows 11 with a release build calling
grep_search_in_workspace(patternfn edit_file,files_with_matches) at the root of a claw-code checkout whoserust/targetholds 2.5 GB / 4,327 files fromcargo test -p runtime -p tools. There were 568 other files. Base and patched binaries ran alternately for 6 rounds of 3 calls each, with a warm file cache:Anti-slop triage
grep_search_skips_common_heavy_directoriesand a new assertion inglob_search_skips_common_heavy_directories. Before the fix grep returns 4 files (.git,node_modules,targetandsrc) where 1 is expected, and a glob rooted innode_modulesreturns 0 files where 1 is expected. Both pass after the fix.Verification
cargo test -p runtime,cargo clippy -p runtime --all-targets -- -D warnings,cargo fmt --all --check, on Windows 11; the full workspace suite was not run locally)git diff --checkpasses.Resolution gate
Compatibility: a
grep_searchfrom a parent directory no longer reports matches inside.git,node_modules,.build,target,distorcoverage. This matchesglob_search.