Repository navigation
fix: Add the Signed-off-by trailer with git interpret-trailers - #283
Merged
Merged
Conversation
The commit-msg hook deleted every line starting with "Signed-off-by" including contributors' sign-offs and body text. It split existing trailer blocks with a blank line and added a blank line on every run. Appending the trailer at the end hid it from the PR check after a "---" line and with a custom comment character left it below the scissors line where git discarded it. Now git adds the trailer only when it's missing. A known limitation remains. With a custom comment character set only in global git config and no -v, each amend adds another trailer paragraph but the PR check still passes. Signed-off-by: BIST pre-commit check
7 of 9 tasks
gabelton
reviewed
Nov 18, 2026
gabelton
approved these changes
Nov 18, 2026
gabelton
left a comment
Contributor
There was a problem hiding this comment.
One suggestion on the test, but not a blocker
Co-authored-by: Gabe Naughton <gabriel.naughton@digital.trade.gov.uk> Signed-off-by: BIST pre-commit check
joshwong-cs
force-pushed
the
fix/signed-off-by-trailer
branch
from
November 18, 2026 09:13
b0112e4 to
56002e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit-msg hook deleted every line starting with "Signed-off-by" including contributors' sign-offs and body text. It split existing trailer blocks with a blank line and added a blank line on every run. Appending the trailer at the end hid it from the PR check after a "---" line and with a custom comment character left it below the scissors line where git discarded it. Now git adds the trailer only when it's missing.
A known limitation remains. With a custom comment character set only in global git config and no -v, each amend adds another trailer paragraph but the PR check still passes.
Signed-off-by: BIST pre-commit check
Description
For a combined summary, please see #282
Contributors
Let's acknowledge the people who contributed to the work.
Type of change
How this has been tested
Please describe the tests that you ran to verify your changes.
If they are not automated tests please explain why and provide screenshots and/or instructions so they can reproduced.
Checklist
Reviewer Checklist