Skip to content

108 support findingaid urls beneath a pr acceptance prefix - #115

Open
Nealium104 wants to merge 4 commits into
mainfrom
108-support-findingaid-urls-beneath-a-pr-acceptance-prefix
Open

Nealium104 wants to merge 4 commits into
mainfrom
108-support-findingaid-urls-beneath-a-pr-acceptance-prefix

Conversation

@Nealium104

Copy link
Copy Markdown
Contributor

This PR enables findingaid to run inside a PR review site (e.g., /review/euk-118/fa/findingaid). It maintains links back to exploreuk-web-app. It reads the same APP_BASE_PATH that the exploreuk-web-app application does through .env.* and puts the base before every link back to the web app. Production and dev leave APP_BASE_PATH empty, so their links will remain unchanged.

Changes

  • Adds APP_BASE_PATH to Config.php, validated with the same rules as exploreuk-web-app
  • Adds appPath() to Controller.php for subject/name search links and deleted findingaid redirects
  • Uses {{app_base}} for links inside mustashe components
  • Refactors the mustashe layout engine to a single method Findingaid::layoutEngine() and passes app_base with a helper, so every layout gets app_base without every render call needing to pass it
  • Adds an app_base meta tag so ui.js recognizes search pages beneath the prefix for the "Back to search results" breadcrumb.
  • Adds BasePathTest.php to validate the config, appPath() function, and checks that every root-relative link carries the base prefix

Related to exploreuk-web-app #181 and ukl-ansible-playbooks #100.

Notes

  • Findingaid's own URLs were already relative or built from SCRIPT_NAME, which ukl-ansible-playbooks #100 already templates with the review prefix.

Fixes #108

@Nealium104
Nealium104 requested a review from a team as a code owner October 15, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Findingaid URLs beneath a PR acceptance prefix

1 participant