Repository navigation
108 support findingaid urls beneath a pr acceptance prefix - #115
Open
Nealium104 wants to merge 4 commits into
Open
Nealium104 wants to merge 4 commits into
Nealium104 wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables findingaid to run inside a PR review site (e.g.,
/review/euk-118/fa/findingaid). It maintains links back to exploreuk-web-app. It reads the sameAPP_BASE_PATHthat the exploreuk-web-app application does through.env.*and puts the base before every link back to the web app. Production and dev leaveAPP_BASE_PATHempty, so their links will remain unchanged.Changes
APP_BASE_PATHtoConfig.php, validated with the same rules as exploreuk-web-appappPath()toController.phpfor subject/name search links and deleted findingaid redirects{{app_base}}for links inside mustashe componentsFindingaid::layoutEngine()and passesapp_basewith a helper, so every layout getsapp_basewithout every render call needing to pass itapp_basemeta tag soui.jsrecognizes search pages beneath the prefix for the "Back to search results" breadcrumb.BasePathTest.phpto validate the config,appPath()function, and checks that every root-relative link carries the base prefixRelated to exploreuk-web-app #181 and ukl-ansible-playbooks #100.
Notes
SCRIPT_NAME, which ukl-ansible-playbooks #100 already templates with the review prefix.Fixes #108