Repository navigation
api: a viewer gone mid-ask is no ask failure - #182
Merged
Merged
Conversation
An ask cut short by its viewer answered 500 and logged analysis_ask_failed; the status read beside it already answered 499 and logged nothing. Ask now takes the same viewerLeft check.
trick77
force-pushed
the
api-ask-viewer-left
branch
from
November 19, 2026 09:02
3f4a702 to
f2af7f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An ask cut short by its viewer answered 500 and logged analysis_ask_failed, while the status read beside it already answered 499 and logged nothing. Ask now takes the same viewerLeft check. Test cases: ask left during Ask (499, no error line), ask there but canceled (still 500 + analysis_ask_failed).
Stacked on #181.