Repository navigation
metrics: drop nil defaults no caller reaches - #172
Merged
Merged
Conversation
trick77
force-pushed
the
metrics-drop-nil-defaults
branch
from
November 19, 2026 08:28
60dfd75 to
30be72e
Compare
Deps.TeamNames and the teams handler sorted the configured teams themselves; config.Config.TeamNames already does.
Compute, Assess and build defaulted a nil previous dataset or baseline; production always passes a loaded previous period (api read, analysis assess). The default moved into the tests' noPrevious and buildAlone; behaviour unchanged.
trick77
force-pushed
the
metrics-drop-nil-defaults
branch
from
November 19, 2026 08:40
30be72e to
94bcc19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compute, Assess and build defaulted a nil previous dataset or baseline. Production always passes a loaded previous period (api read, analysis assess), so the branches only served tests. Tests now pass an empty previous dataset or a repo-naming baseline explicitly; expected values unchanged. Compute/Assess JSON over the existing fixtures is byte-identical before and after.