Skip to content

metrics: drop nil defaults no caller reaches - #172

Merged
trick77 merged 2 commits into
masterfrom
metrics-drop-nil-defaults
Nov 19, 2026
Merged

trick77 merged 2 commits into
masterfrom
metrics-drop-nil-defaults

Conversation

@trick77

@trick77 trick77 commented Nov 19, 2026

Copy link
Copy Markdown
Owner

Compute, Assess and build defaulted a nil previous dataset or baseline. Production always passes a loaded previous period (api read, analysis assess), so the branches only served tests. Tests now pass an empty previous dataset or a repo-naming baseline explicitly; expected values unchanged. Compute/Assess JSON over the existing fixtures is byte-identical before and after.

@trick77
trick77 force-pushed the metrics-drop-nil-defaults branch from 60dfd75 to 30be72e Compare November 19, 2026 08:28
Deps.TeamNames and the teams handler sorted the configured teams themselves; config.Config.TeamNames already does.
Compute, Assess and build defaulted a nil previous dataset or baseline;
production always passes a loaded previous period (api read, analysis
assess). The default moved into the tests' noPrevious and buildAlone;
behaviour unchanged.
@trick77
trick77 force-pushed the metrics-drop-nil-defaults branch from 30be72e to 94bcc19 Compare November 19, 2026 08:40
@trick77
trick77 merged commit 94bcc19 into master Nov 19, 2026
1 check passed
@trick77
trick77 deleted the metrics-drop-nil-defaults branch November 19, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant