Skip to content

dataset: a deploy without images is no release - #163

Merged
trick77 merged 1 commit into
masterfrom
dataset-empty-images-release
Nov 20, 2026
Merged

trick77 merged 1 commit into
masterfrom
dataset-empty-images-release

Conversation

@trick77

@trick77 trick77 commented Nov 19, 2026

Copy link
Copy Markdown
Owner

An Argo CD sync with an empty images list compared unequal with the App's previous images, so it counted as a release and the next sync of the same images counted as another. Such a sync now gets its own window partition in deploys.sql: it is a sync, and the next deploy compares with the images before it. The deployment-frequency query in docs/metrics.md does the same; the new test checks both.

@trick77
trick77 force-pushed the dataset-empty-images-release branch from 28caf97 to 9d1d64d Compare November 19, 2026 07:45
An Argo CD sync with an empty images list compared unequal with the
App's previous images: it counted as a release, and the next sync of
the same images as another. Such a sync now sits in its own window
partition: a sync, even as the App's first deploy, and the next deploy
compares with the previous one naming images; first_seen is the first
deploy naming images. The documented deployment-frequency query does
the same and now partitions by team with id as tie-break, as
deploys.sql does.
@trick77
trick77 force-pushed the dataset-empty-images-release branch from 9d1d64d to a885b31 Compare November 20, 2026 07:12
@trick77
trick77 merged commit 9b35cd2 into master Nov 20, 2026
1 check passed
@trick77
trick77 deleted the dataset-empty-images-release branch November 20, 2026 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant