Repository navigation
Conversation
kv2019i
requested review from
LaurentiuM1234,
abonislawski,
bardliao,
dbaluta,
fkwasowi,
iganakov,
iuliana-prodan,
lbetlej,
lgirdwood,
lyakh,
marcinszkudlinski,
mmaka1,
pblaszko,
plbossart and
tmleman
as code owners
November 6, 2026 10:54
Collaborator
Author
|
Sample test case run on Intel PTL: |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Critical registration and caller-check defects can break normal IPC, DP notifications, and module cleanup, while a user-writable thread handle can grant LL syscall privileges to an unintended thread.
5 open issues
What changed in this PR
This PR narrows SOF’s userspace syscall access by distinguishing infrastructure threads from module threads, reducing the exposed kernel interface.
Changes:
- Adds a default-enabled caller check backed by a kernel-only thread registry.
- Applies role restrictions to syscall validators and registers LL scheduler threads.
- Adds standalone security tests, adapts existing DMA tests, and documents allowed callers.
| File | Description |
|---|---|
zephyr/test/userspace/test_syscall_caller.c |
Adds caller-role and invalid-argument tests. |
zephyr/test/userspace/test_intel_ssp_dai.c |
Registers the test thread with the IPC role. |
zephyr/test/userspace/test_intel_hda_dma.c |
Registers the test thread with the IPC role. |
zephyr/test/CMakeLists.txt |
Enables the new standalone test suite. |
zephyr/syscall/vregion.c |
Restricts virtual-region syscalls to infrastructure threads. |
zephyr/syscall/sof_dma.c |
Restricts DMA syscalls to infrastructure threads. |
zephyr/syscall/dai.c |
Restricts DAI device lookup. |
zephyr/syscall/caller.c |
Implements the kernel-only caller registry. |
zephyr/syscall/alloc.c |
Restricts heap allocation and freeing. |
zephyr/Kconfig |
Adds the default-enabled caller-check option. |
zephyr/CMakeLists.txt |
Conditionally builds the caller registry. |
src/schedule/zephyr_ll.c |
Restricts LL task semaphore management. |
src/schedule/zephyr_dp_schedule.c |
Limits scheduler ticks to LL threads. |
src/schedule/zephyr_dp_schedule_application.c |
Restricts DP task cleanup. |
src/schedule/zephyr_domain.c |
Registers and unregisters LL threads. |
src/library_manager/lib_manager.c |
Uses the registry to authorize module unloading. |
src/ipc/ipc4/notification.c |
Restricts resource notifications. |
src/ipc/ipc4/handler-kernel.c |
Adds role checks to IPC handlers. |
src/ipc/ipc-common.c |
Restricts message sending and queue removal. |
src/include/sof/userspace/syscall_caller.h |
Defines roles, registration APIs, and check macros. |
src/include/sof/userspace/README.md |
Documents caller permissions and validator requirements. |
src/debug/debug_stream/debug_stream_slot.c |
Restricts debug record submission. |
src/audio/kpb.c |
Restricts KPB notifier initialization. |
Review effort: Balanced
| uint32_t resource_type, void *data, | ||
| uint32_t data_size) | ||
| { | ||
| SOF_SYSCALL_CALLER_CHECK(SOF_SYSUSER_INFRA); |
Collaborator
Author
There was a problem hiding this comment.
A good catch, this is valid. Fixed in V2.
PR 11408: test resultsRun date: 2026-11-06 11:27 UTC Tested commit: 5baf828f61a14b13c1a870a424728247e0f30ca0
|
Zephyr lets any user thread invoke any system call. SOF user threads have different trust levels: the LL scheduler and IPC user threads are SOF infrastructure, while DP threads run module code that can come from a third party. Add a registry in kernel-only memory that records the LL and IPC user thread of each core, and sof_syscall_caller_allowed() for validators to check the calling thread against a set of roles. Register the threads where they are created, before they start, and clear the LL entry before the thread object is freed. The registry is enabled with the new SOF_USERSPACE_SYSCALL_CALLER_CHECK option, default y with SOF_USERSPACE_LL. No validator uses it yet. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Use the caller registry in the validators of SOF system calls, so DP module threads can only reach the syscalls needed to implement the module interface, including sending notifications: - any user thread: cpu_get_id, the mod_* module syscalls, ipc_msg_send, ipc_msg_list_remove and send_resource_notif - IPC user thread only: ipc_compound_pre_start, ipc_compound_post_start, ipc_wait_for_compound_msg, lib_manager_free_module - LL user thread only: scheduler_dp_ll_tick - LL or IPC user thread: all other SOF syscalls DP modules send notifications with mod_ipc_msg_init() and ipc_msg_send(), free them with mod_ipc_msg_free() from their .free() callback, and dp_task_run() reports processing errors with send_resource_notif(), so these stay open to all user threads. lib_manager_free_module() previously identified the IPC thread through ipc_user->thread[], which user threads can write. It now uses the registry, keeping the old check only if the option is disabled. The HDA DMA and SSP DAI userspace tests call DMA syscalls from their own user thread, so register that thread for the duration of the test. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Add the missing kpb_notifier_init and mod_data_blob_set entries to the syscall map, document which threads may call which syscalls, and extend the rules for adding syscalls with the caller check, single fetch of user data and not following user-writable pointers in the kernel. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Add standalone boot tests that check the caller restriction, rejection of a forged vregion handle, and the DMA channel range and transfer direction checks. Cases that need features the target lacks are skipped. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
force-pushed
the
202611-syscall-restrictions
branch
from
November 6, 2026 16:49
5baf828 to
c171548
Compare
Collaborator
Author
|
V2 pushed:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A set of PRs to add infra to limit syscalls to a subset of threads. This allows to limit attack surface of syscalls. This doesn't remove need to secure the syscalls LL/IPC threads use, but limits the exposure significantly without any functional impact and makes the user-kernel separation more easy to verify and understand.
A standalone test case is added to test the constraints.