Repository navigation
Conversation
Add HDMI_IN to SOF_LINK_ORDER so that the HDMI IN dai links will be createrd if SSP_MASK_HDMI_CAPTURE is set to board_quirk. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
bardliao
requested review from
kv2019i and
ujfalusi
and
a balanced review from Copilot
October 30, 2026 05:48
There was a problem hiding this comment.
🟡 Changes recommended
The HDMI-name filter incorrectly disables the new capture backends when no iDisp codec is present, leaving HDMI input unavailable despite the board quirk enabling it.
1 open issue
What changed in this PR
Adds HDMI input DAI link support to the generic Intel SOF HDA machine driver when SSP_MASK_HDMI_CAPTURE is enabled in the board quirk.
Changes:
- Adds HDMI input to the driver's DAI link order.
- Assigns HDMI input a starting backend ID of 9.
| File | Description |
|---|---|
sound/soc/intel/boards/skl_hda_dsp_generic.c |
Adds the HDMI input link type and corresponding backend ID to the link configuration. |
Review effort: Balanced
bardliao
requested review from
dbaluta,
lgirdwood,
plbossart and
ranj063
as code owners
October 30, 2026 11:16
There was a problem hiding this comment.
🟡 Changes recommended
The iDisp-absent filtering disables required backends rather than HDMI playback frontends in both board drivers, causing affected topologies to fail sound-card registration.
1 open issue
1 resolved since last review
Review effort: Balanced
When iDisp is absent, limit the HDMI ignore check to playback FE links. HDMI-In links use names such as SSP%d-HDMI, and their stream_name may contain HDMI as well. Excluding BE and capture-only links prevents the HDMI-In capture link from being ignored. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
When iDisp is absent, limit the HDMI ignore check to playback FE links. HDMI-In links use names such as SSP%d-HDMI, and their stream_name may contain HDMI as well. Excluding BE and capture-only links prevents the HDMI-In capture link from being ignored. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
bardliao
force-pushed
the
hdmiin-with-HDA-codecs
branch
from
October 30, 2026 13:37
f201d24 to
21b8602
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add HDMI_IN to SOF_LINK_ORDER so that the HDMI IN dai links will be createrd if SSP_MASK_HDMI_CAPTURE is set to board_quirk.