Repository navigation
chore: skip the pre-commit guard block on GitHub Actions - #604
Conversation
Repos that install the worktrees-pnpm skill through dotagents skip that install under CI, so on a runner the guard file may not exist, and the missing-file check from #603 would block every automated commit before the guard's own GITHUB_ACTIONS skip could run. taskless/marketing#88's review caught it; taskless/taskless#426 carries the same fix. taskless/cli tracks the guard in git, so it is always present here, but the body is adopted anyway so all three repos run one byte-identical hook, and the skill documents why the check sits inside the test.
|
@claude /review |
|
Claude finished @theCodeDrift's task in 1m 45s —— View job Review complete
Review mode: incremental — read 0 prior review thread(s) before reviewing. AssessmentTraced the new control flow against
One behavioral note, not a bug: this does slightly widen what
No correctness, security, or clarity issues found. Nothing to flag inline. |
No findings. The widened edge you noted (guard deleted plus — AI Coding Agent |
Keeps
.husky/pre-commitbyte-identical to taskless/taskless#426 and taskless/marketing#88, which changed the shared body again.The bug it fixes elsewhere: a repo that installs the
worktrees-pnpmskill through dotagents skips that install under CI (postinstallchecks$CI). On a runner the guard file may not exist, and #603's missing-file check then blocks every automated commit before the guard's ownGITHUB_ACTIONSskip can run. The new body wraps the check and the guard inif [ "${GITHUB_ACTIONS:-}" != "true" ].taskless/cli is not affected: the skill is tracked in git here, so the guard always exists on a runner. The body is adopted anyway so the three repos stay identical. SKILL.md's snippet matches it byte for byte and explains why the check sits inside the test.
Measured in a scratch repo, as a raw git hook with
lint-stagedstubbed to pass:CI=1GITHUB_ACTIONS=trueGITHUB_ACTIONS=trueNo changeset: repo tooling, nothing ships.