Repository navigation
fix(worker): use selector event loop for ZeroMQ workers on Windows - #717
Open
Wayfarer545 wants to merge 1 commit into
Open
Wayfarer545 wants to merge 1 commit into
Wayfarer545 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #524
On Windows, a worker with
ZeroMQBrokercrashes on its first receive: the defaultProactorEventLoophas noadd_reader, which pyzmq needs unless tornado is installed.ProcessManagerkeeps restarting the worker, so the main process looks healthy but notasks run. Setting an event loop policy in the app doesn't help, because the loop is
created before the broker is imported.
The worker now replaces
ProactorEventLoopwithSelectorEventLoopright after thebroker is imported, only on Windows and only for
ZeroMQBroker.This is narrower than the "pyzmq is installed" check discussed in the issue. pyzmq is
often a transitive dependency (e.g. via ipykernel), and the selector loop doesn't support
asyncio.create_subprocess_*, so that check would silently break subprocesses for usersof other brokers.
Limitations of the selector loop for ZeroMQ workers on Windows:
asyncio.create_subprocess_*isn't available in tasks.taskiq workerstill exits immediately, butWORKER_SHUTDOWNhandlers don't run.replaced loop and fail with
attached to a different loop.Setups with tornado installed worked on
ProactorEventLoopbefore, with aRuntimeWarning,and now lose subprocess support and shutdown handlers on idle Ctrl+C too.
Tested with a real worker process on Windows (Python 3.10, 3.13 and 3.14) and on Linux
(Python 3.10). Not tested on macOS.