Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Returning a
JSValuethat Swift created crashed:JSValue.bridgeJSStackPushconsumedselfbefore it retained the payload, so the last reference was already released. The retain now runs insidewithRawJSValue.Values that came from JavaScript did not crash, because they leaked. The JS lower retained the payload and
JSValue.bridgeJSLiftParameterretained it again. In the other direction, Swift retained a returned payload and the JS lift never released it. JSValue now follows theJSObjectrule: the sender retains and the receiver takes ownership. The Swift lift no longer retains, and the JS lift of returned and container values releases through a new__bjs_jsValueTakehelper. Direct Swift-to-JS parameters stay borrowed. A privateJSValueKindenum now holds the kind tags, so the glue no longer repeats which kinds carry a reference.Testing
Added
makeJSValueStringandmakeJSValueObject, and asserts that no reference stays in the JS heap afterroundTripJSValueandroundTripOptionalJSValueArray. Snapshot tests andmake unittestpass.