Repository navigation
Split ipv6 addresses properly. - #66
Merged
Merged
Conversation
Use net.SplitHostPort for splitting hosts and ports, instead of doing string splitting operations directly. This handles IPv6 literals properly, which can contain colons. However, we also need to allow for port defaulting. So detect the cases where SplitHostPort fails because of a missing port, and fill in the default port in these cases. Wrap it up in a tidy API that works like net.SplitHostPort, with some test cases, so that this code could be reused and the code modifications are isolated.
timflyio
marked this pull request as ready for review
November 18, 2026 00:16
Contributor
Author
|
Based on ideas from #65. |
jeregrine
requested changes
Nov 18, 2026
Dialfunc is always called with a specified port number, so handling the case where the port is not specified and filled in implicitly is not needed.
jeregrine
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use net.SplitHostPort for splitting hosts and ports, instead of doing string splitting operations directly. This handles IPv6 literals properly, which can contain colons. However, we also need to allow for port defaulting. So detect the cases where SplitHostPort fails because of a missing port, and fill in the default port in these cases. Wrap it up in a tidy API that works like net.SplitHostPort, with some test cases, so that this code could be reused and the code modifications are isolated.