Skip to content

Finish lease acquisition spans and record failures - #5502

Merged
benbjohnson merged 1 commit into
masterfrom
benbjohnson/finish-lease-acquisition-trace-20261119-101900
Nov 19, 2026
Merged

benbjohnson merged 1 commit into
masterfrom
benbjohnson/finish-lease-acquisition-trace-20261119-101900

Conversation

@benbjohnson

Copy link
Copy Markdown
Contributor

Deploy’s acquireLeases starts an acquire_leases span without ending it, so completed attempts can disappear from exported traces. Returned lease failures are recorded as exception events without a failed span status.

End the span on every return and use the existing tracing.RecordError helper when the lease group fails. This preserves the original exception and marks the phase failed. Successful lease acquisition keeps its existing behavior.

The full local go test ./... suite and deploy package tests passed. This addresses missing lease phases observed during the Journeys one-hour cohort review; the analyzer separately recovers historical failures from retained request evidence.

This PR adds no new failure classification rules.

Non-test code +2 / −1. Test code +0 / −0.

@benbjohnson
benbjohnson requested a review from a team as a code owner November 19, 2026 12:34
@benbjohnson benbjohnson reopened this Nov 19, 2026
@benbjohnson
benbjohnson merged commit 8f2258c into master Nov 19, 2026
66 of 67 checks passed
@benbjohnson
benbjohnson deleted the benbjohnson/finish-lease-acquisition-trace-20261119-101900 branch November 19, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant