Repository navigation
Finish lease acquisition spans and record failures - #5502
Merged
benbjohnson merged 1 commit intoNov 19, 2026
Merged
benbjohnson merged 1 commit into
benbjohnson merged 1 commit into
Conversation
benbjohnson
deleted the
benbjohnson/finish-lease-acquisition-trace-20261119-101900
branch
November 19, 2026 13:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploy’s
acquireLeasesstarts anacquire_leasesspan without ending it, so completed attempts can disappear from exported traces. Returned lease failures are recorded as exception events without a failed span status.End the span on every return and use the existing
tracing.RecordErrorhelper when the lease group fails. This preserves the original exception and marks the phase failed. Successful lease acquisition keeps its existing behavior.The full local
go test ./...suite and deploy package tests passed. This addresses missing lease phases observed during the Journeys one-hour cohort review; the analyzer separately recovers historical failures from retained request evidence.This PR adds no new failure classification rules.
Non-test code +2 / −1. Test code +0 / −0.