You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have maintained this fork for sometime and use it in OpenStack deployments via Kayobe. It uses branch main as the default so we add a new Kayobe branch protection rule.
The alternative is that we put it under SRE since it's not tied to Kayobe, just used with it. We would then need to change codeowners.
Adds redfish_exporter as a single-branch source repository with Monitoring CODEOWNERS. Adds a Monitoring team with push access and branch protection for its repositories. Sets build as the required status check for redfish_exporter.
The change adds the Monitoring team and registers redfish_exporter under that team. It configures monitoring CODEOWNERS content, a required build status check, team push access, and branch protection for Monitoring repositories.
Changes: Monitoring repository onboarding
Layer / File(s)
Summary
Configure Monitoring and redfish_exporter ansible/inventory/group_vars/all/source-repositories, terraform/github/variables.tf, terraform/github/terraform.tfvars.json
Adds the Monitoring team configuration and registers redfish_exporter with monitoring CODEOWNERS content. Adds build as the repository’s default required status check.
Grant Monitoring repository access terraform/github/teams.tf
Grants the Monitoring team push permission to each repository in its configured repository list.
Adds branch protection for each Monitoring repository’s default branch. The protection requires conversation resolution and one code-owner-reviewed approval, blocks deletion and force pushes, allows pushes by the Developers team, uses configured default status checks or an empty list, and prevents destruction.
stackhpc/stackhpc-release-train#586: Changes how source-repo-sync updates community files and their pull requests, including the CODEOWNERS file configured for redfish_exporter.
Merge Risk: Moderate · up to d2d64
The new Monitoring team will make the repository import workflow fail with a KeyError, which blocks onboarding of the existing redfish_exporter repository. Update the importer to handle Monitoring, then run the import and obtain a new plan before merging.
Pre-merge checks: 3
Check name
Status
Explanation
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (5 skipped: 5 unsupported.)
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Tip
🎯 Customize your risk assessments
Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.
✅ Automatic approvals, with your rules
Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
The reason will be displayed to describe this comment to others. Learn more.
Major · Stability & Availability · Quick win
Supported by static analysis
Script executed:
sed -n '1,105p' terraform/github/branches.tf
sed -n '285,430p' terraform/github/branches.tf
sed -n '90,130p' docs/usage/github-organisation-management.md
sed -n '35,70p' terraform/github/terraform.tfvars.json
Repository: stackhpc/stackhpc-release-train
Length of output: 11097
Keep this rule's instance when a Kayobe repository changes its default branch.
The for_each at terraform/github/branches.tf:373-376 keeps a repository only while its default_branch is main. When a repository changes its default branch, Terraform plans to destroy that instance. The block sets prevent_destroy = true, so Terraform rejects the plan. The workspace plan then fails until an operator runs terraform state rm in Terraform Cloud. The trigger is rare, but recovery needs access to the Terraform Cloud GitHub workspace.
Decide the intended scope before you change the key. The Ansible and Batch resources set pattern from default_branch for all repositories in their list. Applying that pattern here protects the default branch of every Kayobe repository, not only repositories whose default branch is main. If a Kayobe repository uses stackhpc/master or stackhpc/2026.1 as its default branch, its pattern duplicates an existing rule in kayobe_branch_protection_master or kayobe_branch_protection_gazpacho. After you confirm the scope, use a stable for_each key and set pattern to match it.
Tools
Checkov (3.3.29)
[low] 372-405: Ensure GitHub branch protection rules requires signed commits
(CKV_GIT_6)
[medium] 372-405: GitHub pull requests should require at least 2 approvals
We have maintained this fork for some time and use it in OpenStack
deployments via Kayobe. Since it is not tied to Kayobe, just used
with it, we add a new Monitoring team to own it. Membership mirrors
the OpenStack team.
Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
We have maintained this fork for sometime and use it in OpenStack deployments via Kayobe. It uses branch
mainas the default so we add a new Kayobe branch protection rule.The alternative is that we put it under SRE since it's not tied to Kayobe, just used with it. We would then need to change codeowners.
Assisted-By: Claude Opus 5.5 noreply@anthropic.com