Repository navigation
Conversation
#1998 moved contract/ to Apache-2.0 on 10 November. contract/LICENSE, contract/README.md and CONTRIBUTING.md say so, but LICENSING.md still called go/protocol the only exception and NOTICE recorded only the wire-format module. Both now name the two Apache-2.0 paths. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
miravoss26
left a comment
There was a problem hiding this comment.
Docs only: LICENSING.md now lists contract/ next to go/protocol as Apache-2.0 exceptions, and NOTICE gets a dated section for contract/ in the same form as the protocol one.
- No security findings. No code, deps or hosts touched.
- Text matches what the PR says #1998 did (10 Nov); "Core links it and reads the contracts" is accurate as a non-change to Core's license.
- One check shows CANCELLED ("changeset present (or auto-exempt)"); everything else is green or skipped. Likely a superseded run, worth a re-run before merge.
Needs a human decision on the open question in the description: #1588 waited for a lawyer on go/protocol, and contract/ was AGPL from 12 Sep to 10 Nov, so the same sign-off may apply before this lands. Otherwise safe to merge from my read.
Problem
#1998 moved
contract/to Apache-2.0 on 10 November.contract/LICENSE,contract/README.mdand CONTRIBUTING.md say so. LICENSING.md still callsgo/protocol"the exception", and NOTICE records only the wire-format module.Change
contract/andgo/protocol.contract/, in the same form as the one forgo/protocol.No code changes, so this PR carries the
no-changesetlabel.Evidence
scripts/test_package_linux.py,scripts/test_package_legacy_linux.pyandscripts/test_history_converter_package.pypass locally (16 tests). The packaging scripts reference these files.Open question
The
go/protocolrelicensing waited for a lawyer to confirm it (#1588). The same check may apply tocontract/, whose files were AGPL from 12 September to 10 November.Found while checking license text across the FTW repositories. srcfl/ftw-webapp has a separate fix for its relay and escrow READMEs; neither PR depends on the other.
🤖 Generated with Claude Code