Repository navigation
test: the graph-install cell runs in its own process (fixes the templates flake on main) - #18
Merged
Merged
Conversation
…lake is gone Main's push CI failed twice (after #2, after #5) on the same two templates cells: a reader of HexGraph::current() saw a graph without its nodes. The 16-thread install cell installs 64 synthetic graphs into the process-wide ArcSwap, and its serial(hexser_arch) lock never covered the unit tests that read the registered graph. Latent since 0.6.1. Red first: 37 of 300 local runs of the lib test binary failed at 32 threads. The identity and install cells move to tests/arch_install_test.rs as one cell, in a process of their own, so serial_test leaves the dev-dependencies. After: 0 of 300 full lib runs failed. Gates: fmt, clippy --all-targets -D warnings, audit, deny exit 0; tests 345 / 456 / 336, 0 failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's push CI failed twice after Dependabot merges (#2 at 5e42ee2, #5 at 59a17f6), each time on the same two
templatescells: "the port node the edge targets is a node in the graph". No dependency caused it.Cause:
test_arcswap_16_thread_read_during_installinstalls 64 synthetic graphs into the process-wideHexGraphArcSwap. Itsserial(hexser_arch)lock covered only the other identity cell, never the unit tests that read the registered graph throughHexGraph::current(), so a reader could load a synthetic graph mid-run. Latent since 0.6.1.Red first: 37 of 300 local runs of the lib test binary failed at 32 threads.
Fix: both arch cells move to
hexser/tests/arch_install_test.rsas one cell. An integration test is a process of its own, so no reader shares it, no lock is needed, andserial_testleaves the dev-dependencies. The library is unchanged.After: 0 of 300 full lib runs failed. fmt, clippy
--all-targets -D warnings,cargo auditandcargo deny checkexit 0; tests 345 default / 456 all-features / 336 macros-only, 0 failed (one fewer: two cells became one).This lands before the v0.7.0 tag so the tagged tree has no known flaky cell.