Skip to content

test: the graph-install cell runs in its own process (fixes the templates flake on main) - #18

Merged
scott-wyatt merged 2 commits into
mainfrom
hardening/pr0-signal-260720
Nov 17, 2026
Merged

scott-wyatt merged 2 commits into
mainfrom
hardening/pr0-signal-260720

Conversation

@scott-wyatt

Copy link
Copy Markdown
Contributor

Main's push CI failed twice after Dependabot merges (#2 at 5e42ee2, #5 at 59a17f6), each time on the same two templates cells: "the port node the edge targets is a node in the graph". No dependency caused it.

Cause: test_arcswap_16_thread_read_during_install installs 64 synthetic graphs into the process-wide HexGraph ArcSwap. Its serial(hexser_arch) lock covered only the other identity cell, never the unit tests that read the registered graph through HexGraph::current(), so a reader could load a synthetic graph mid-run. Latent since 0.6.1.

Red first: 37 of 300 local runs of the lib test binary failed at 32 threads.

Fix: both arch cells move to hexser/tests/arch_install_test.rs as one cell. An integration test is a process of its own, so no reader shares it, no lock is needed, and serial_test leaves the dev-dependencies. The library is unchanged.

After: 0 of 300 full lib runs failed. fmt, clippy --all-targets -D warnings, cargo audit and cargo deny check exit 0; tests 345 default / 456 all-features / 336 macros-only, 0 failed (one fewer: two cells became one).

This lands before the v0.7.0 tag so the tagged tree has no known flaky cell.

…lake is gone

Main's push CI failed twice (after #2, after #5) on the same two templates
cells: a reader of HexGraph::current() saw a graph without its nodes. The
16-thread install cell installs 64 synthetic graphs into the process-wide
ArcSwap, and its serial(hexser_arch) lock never covered the unit tests that
read the registered graph. Latent since 0.6.1.

Red first: 37 of 300 local runs of the lib test binary failed at 32
threads. The identity and install cells move to tests/arch_install_test.rs
as one cell, in a process of their own, so serial_test leaves the
dev-dependencies. After: 0 of 300 full lib runs failed.

Gates: fmt, clippy --all-targets -D warnings, audit, deny exit 0; tests
345 / 456 / 336, 0 failed.
criterion 0.7 (Dependabot #7) deprecates criterion::black_box, so #7 fails
clippy --all-targets -D warnings. std::hint::black_box serves criterion
0.5 and 0.7 alike, so this lands first and #7 then merges as written.
@scott-wyatt
scott-wyatt merged commit c4e26a5 into main Nov 17, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant