Repository navigation
perf(rules): find unused CTEs without cloning each WITH query - #30
Merged
Merged
Conversation
SQLCLEAN005 cloned every query that carries a WITH clause, including all of its CTE bodies, only to drop the WITH and read the remaining table names. Count table references in the whole query and subtract those inside the WITH instead, so a name read both inside and outside still counts as used.
Deploying sqlclean with
|
| Latest commit: |
1fed2d1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://63133f4f.sqlclean.pages.dev |
| Branch Preview URL: | https://perf-unused-cte-no-clone.sqlclean.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Default SQL Rules made SQLBuild's cold compile slower. Profiling the lint batch from a 3,000-model project (2,249 requests) showed SQLCLEAN005 deep-cloning every query that has a WITH clause, CTE bodies included, just to read the table names outside the WITH.
Changes
Verification
cargo fmt --check,cargo clippy --all-targets -- -D warnings,cargo test -p sqlcleanandfensu checkpass.