Repository navigation
feat(rules): let a host supply the SQLCLEAN044 guidance - #20
Merged
Merged
Conversation
A lint request can now set long_literal_guidance, which replaces SQLClean's advice to shorten the literal or move it into a reference table. SQLBuild uses it to point at its own constants.
Deploying sqlclean with
|
| Latest commit: |
e9359c0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://010c08ed.sqlclean.pages.dev |
| Branch Preview URL: | https://feat-long-literal-guidance.sqlclean.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SQLCLEAN044 always advises shortening a long literal or moving it into a reference table or query parameter. A host such as SQLBuild has its own way to share a value (a declared constant), and its users should see that advice instead. Before SQLClean took over the Rule, SQLBuild users got that advice.
Changes
long_literal_guidance. When set, SQLCLEAN044 gives it in place of SQLClean's own sentence, followed by the usualmax_literal_lengthsetting.Verification
config_fileand checks the host sentence leads the help while SQLClean's sentence and file name are absent; it fails on main.make verify,make test-integration test-e2e, clippy on 1.95 and the hygiene scan pass.