Repository navigation
fix: set org.opencontainers.image.version on the per-platform images - #78
Merged
Merged
Conversation
…ages The build derived no tags outside workflow_dispatch, so metadata-action wrote an empty version into the config labels and manifest annotations. Use the same tag rules as create-manifest, add a version input (also on build.yml) and drop empty labels/annotations.
Both shims now resolve the version as the tag without its leading v, so the index and platform images agree, including for variants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build-imagenow uses the same tag rules ascreate-manifest, so platform manifests and config labels get the version (1.19.0,pr-N, branch name) instead of""versioninput onbuild-imageandbuild.yml; empty labels/annotations are dropped before the buildbuild-go-cli/merge-go-cliboth resolve the version as the tag withoutv, so build and index agree (variant index now reports1.2.3instead of1.2.3-alpine)raw-tags/flavoron merge should pass the sameversionto the buildDecisions and skipped steps
versioninput over addingraw-tags/flavorto the buildload: trueconsumer build; needs a release and consumer bumps afterwards