Repository navigation
feat!: merge builder_nodejs into builder in the PHP workflows (3.0.0) - #77
Merged
Merged
Conversation
The PHP images are merging their builder_nodejs Dockerfile stage into builder, so build-php.yml and merge-php.yml no longer build or merge a separate builder_nodejs target. merge-php.yml publishes the builder manifest under /builder, /builder_nodejs and /node so downstream projects pulling the old names keep working. /builder stays first: create-manifest takes the digests from the first name. BREAKING CHANGE: the builder_nodejs build and merge jobs are gone, along with the title-builder_nodejs and description-builder_nodejs inputs of merge-php.yml. /builder_nodejs and /node now point at the builder stage, so callers must drop their separate builder_nodejs stage in the same change, and remove the builder_nodejs Merge Images checks from their rulesets. Refs #75
build-php.yml and merge-php.yml now handle two targets. The builder includes Node.js and is also published as /builder_nodejs and /node, which are kept for downstream projects and deprecated. Refs #75
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #75
Summary
build-php.ymlandmerge-php.ymlhandle onlyruntimeandbuilder; thebuilder_nodejsjobs are gonemerge-php.ymlpublishesbuilderas/builder,/builder_nodejsand/node(/builderfirst, socreate-manifesttakes its digests)title-builder_nodejs/description-builder_nodejsinputs removed3.0.0Breaking changes (for the 3.0.0 release notes)
/builder_nodejsand/nodepoint atbuilderbuilder_nodejsMerge Images required checks no longer exist; remove them from rulesetstitle-builder_nodejsordescription-builder_nodejsis now an errorDecisions and skipped steps
docs/pipeline.md, which described three PHP stages and thenodealias3.0.0-rc.1on cb1aeb5 (internal refs still@2.4.4, actions unchanged), not on the bump commit, which points at the not-yet-existing@3.0.0