Repository navigation
Import headers from a .gzf without SARIF - #411
Merged
Merged
Conversation
ghidra-importer.py --gzf (reimport-ghidra.ps1 -Gzf) reads the program straight from the gzf with skink's Project.from_gzf, which needs pyghidra. The headers are the same as from the SARIF route, in about half a minute instead of about ten. Duplicates from find_all_by_location are removed with skink's unique(), which gives the same result as the `obj not in objs` loop without comparing every pair. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XmXCmZDK7Sy2VkmmyZnN39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reimport-ghidra.ps1 -Gzf "Stronghold Crusader.exe.gzf"generates the headers straight from a Ghidra.gzf, with no SARIF export. It takes about half a minute instead of about ten, and the headers are the same.Changes
ghidra-importer.py --gzfreads the program with skink'sProject.from_gzf, which uses pyghidra;gzftosarif.pyalready depends on it.GHIDRA_INSTALL_DIRmust be set. Without--gzf, the SARIF route works as before.reimport-ghidra.ps1 -Gzfpasses it through and skips the SARIF generation.find_all_by_locationare removed with skink'sunique(). It gives the same result as theobj not in objsloop without comparing every pair, which took about 25 s.tools/import/README.mddocuments the gzf route.Depends on gynt/ghidra-skink#10.
requirements.txtinstalls skink frommain, so that PR has to be merged first; until then the importer can't findProject.from_gzforunique().Verification: both routes give byte-identical headers (1932 files) and the same warnings as the current importer.
skink ghidra verifyreports all 143,367 records identical between the gzf and the SARIF export.🤖 Generated with Claude Code