Skip to content

enhance: use Dispatcher.UIThread.Post to hand refresh results to the UI thread #2871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bertyhell wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

enhance: use Dispatcher.UIThread.Post to hand refresh results to the UI thread #2871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ViewModels/Launcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ private void DispatchNotification(Models.Notification notification)
{
if (!Dispatcher.UIThread.CheckAccess())
{
Dispatcher.UIThread.Invoke(() => DispatchNotification(notification));
Dispatcher.UIThread.Post(() => DispatchNotification(notification));
return;
}

Expand Down
16 changes: 8 additions & 8 deletions src/ViewModels/Repository.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1182,7 +1182,7 @@ public void RefreshBranches()
var remotes = await new Commands.QueryRemotes(FullPath).GetResultAsync().ConfigureAwait(false);
var builder = BuildBranchTree(branches, remotes);

Dispatcher.UIThread.Invoke(() =>
Dispatcher.UIThread.Post(() =>
{
if (token.IsCancellationRequested)
return;
Expand Down Expand Up @@ -1218,7 +1218,7 @@ public void RefreshWorktrees()
{
var worktrees = await new Commands.Worktree(FullPath).ReadAllAsync().ConfigureAwait(false);
var cleaned = Worktree.Build(FullPath, worktrees);
Dispatcher.UIThread.Invoke(() => Worktrees = cleaned);
Dispatcher.UIThread.Post(() => Worktrees = cleaned);
});
}

Expand All @@ -1233,7 +1233,7 @@ public void RefreshTags()
Task.Run(async () =>
{
var tags = await new Commands.QueryTags(FullPath).GetResultAsync().ConfigureAwait(false);
Dispatcher.UIThread.Invoke(() =>
Dispatcher.UIThread.Post(() =>
{
if (token.IsCancellationRequested)
return;
Expand Down Expand Up @@ -1292,7 +1292,7 @@ public void RefreshCommits()
}
}

Dispatcher.UIThread.Invoke(() =>
Dispatcher.UIThread.Post(() =>
{
if (token.IsCancellationRequested)
return;
Expand All @@ -1318,7 +1318,7 @@ public void RefreshSubmodules()
{
if (_submodules.Count > 0)
{
Dispatcher.UIThread.Invoke(() =>
Dispatcher.UIThread.Post(() =>
{
Submodules = [];
VisibleSubmodules = BuildVisibleSubmodules();
Expand All @@ -1332,7 +1332,7 @@ public void RefreshSubmodules()
{
var submodules = await new Commands.QuerySubmodules(FullPath).GetResultAsync().ConfigureAwait(false);

Dispatcher.UIThread.Invoke(() =>
Dispatcher.UIThread.Post(() =>
{
bool hasChanged = _submodules.Count != submodules.Count;
if (!hasChanged)
Expand Down Expand Up @@ -1389,7 +1389,7 @@ public void RefreshWorkingCopyChanges()

changes.Sort((l, r) => Models.NumericSort.Compare(l.Path, r.Path));

Dispatcher.UIThread.Invoke(() =>
Dispatcher.UIThread.Post(() =>
{
if (token.IsCancellationRequested)
return;
Expand All @@ -1416,7 +1416,7 @@ public void RefreshStashes()
Task.Run(async () =>
{
var stashes = await new Commands.QueryStashes(FullPath).GetResultAsync().ConfigureAwait(false);
Dispatcher.UIThread.Invoke(() =>
Dispatcher.UIThread.Post(() =>
{
if (token.IsCancellationRequested)
return;
Expand Down