Repository navigation
Conversation
|
|
✅ Deploy Preview for solid-docs-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #1683 with a second prose pass over the Learn pages (getting started, concepts, building apps, routing, guides, migration, glossary) and the tutorial lessons. Reference pages are not touched; most of them are generated from the Solid JSDoc.
The pass used the unslop skill's rules in docs register, with WRITING.md winning where they disagree. It removed these patterns:
Headings, code blocks, links, frontmatter, callouts and the Recap and Next steps sections are unchanged. About 15 pages already read clean and have no edits. No edit adds a fact; each rewrite keeps the original claim at the same strength.
This is a WIP draft. Each page's owner should read their own diff, since a few sentences were reworded around claims that need a source check.
Verification
pnpm lint:tone: 0 errors. The one warning is in a generated reference page..mdxfile compiles with@mdx-js/mdxandremark-frontmatter.codex exec review --base origin/v2-rebuildfound no regressions.vite buildhas not been run.Open questions for page owners
These came up during the pass and were left unchanged:
ReferenceError: window is not defined, but the next sentence says the module readlocalStorage.start()code on the page writes on every chunk.🤖 Generated with Claude Code