Skip to content

[Framework] Cmake: set warnings-as-errors in all the Framework targets - #6145

Merged
bakpaul merged 1 commit into
sofa-framework:masterfrom
fredroy:framework_warnings_as_errors
Nov 12, 2026
Merged

bakpaul merged 1 commit into
sofa-framework:masterfrom
fredroy:framework_warnings_as_errors

Conversation

@fredroy

@fredroy fredroy commented Jun 8, 2026 •

Copy link
Copy Markdown
Contributor

Based on

The continuation of #5914 ,#6027, #6028, #6034......
This should make the compilation of the target Sofa.Framework warning-free.... with the current flags.

[with-all-tests]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Jun 8, 2026
@fredroy fredroy changed the title [Framwork] Cmake: set warnings-as-errors in all the Framework targets [Framework] Cmake: set warnings-as-errors in all the Framework targets Jun 8, 2026
@fredroy
fredroy force-pushed the framework_warnings_as_errors branch 6 times, most recently from 9048206 to d2e7617 Compare June 8, 2026 23:40
@fredroy

fredroy commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

[ci-build][with-all-tests]

@fredroy fredroy added the pr: based on previous PR PR based on a previous PR, therefore to be merged ONLY subsequently label Jun 9, 2026
@fredroy
fredroy force-pushed the framework_warnings_as_errors branch from d2e7617 to 04cd3bd Compare June 9, 2026 23:08
@hugtalbot

Copy link
Copy Markdown
Contributor

When updating of VMs / CIs, warnings are to be expected therefore creating errors. Let's discuss this with @bakpaul

@hugtalbot hugtalbot added this to the v26.06 milestone Jun 12, 2026
@fredroy
fredroy force-pushed the framework_warnings_as_errors branch from 04cd3bd to 02ee377 Compare June 14, 2026 21:58
@fredroy fredroy removed the pr: based on previous PR PR based on a previous PR, therefore to be merged ONLY subsequently label Jun 14, 2026
@bakpaul

bakpaul commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Yes indeed, I would like to merge it after the CI migration !

@alxbilger alxbilger added the pr: highlighted in next release Highlight this contribution in the notes of the upcoming release label Jun 18, 2026
@fredroy fredroy modified the milestones: v26.06, v26.12 Jun 18, 2026
@fredroy
fredroy force-pushed the framework_warnings_as_errors branch from cdf7516 to 707296d Compare June 26, 2026 07:04
@fredroy
fredroy force-pushed the framework_warnings_as_errors branch from 707296d to 46ac27b Compare July 8, 2026 22:50
@fredroy
fredroy force-pushed the framework_warnings_as_errors branch from 46ac27b to 9fe8103 Compare July 20, 2026 22:32
@fredroy fredroy added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Sep 10, 2026
@fredroy
fredroy force-pushed the framework_warnings_as_errors branch from 9fe8103 to b15ad55 Compare October 7, 2026 00:23
@fredroy
fredroy force-pushed the framework_warnings_as_errors branch from b15ad55 to 8cb4e75 Compare October 25, 2026 23:56
@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Oct 26, 2026
@fredroy
fredroy force-pushed the framework_warnings_as_errors branch from 9d9e009 to 15c954d Compare October 30, 2026 04:22
@fredroy fredroy added the pr: based on previous PR PR based on a previous PR, therefore to be merged ONLY subsequently label Oct 30, 2026
@hugtalbot
hugtalbot self-requested a review November 5, 2026 09:06
@fredroy
fredroy force-pushed the framework_warnings_as_errors branch 3 times, most recently from e31112e to 030d586 Compare November 12, 2026 02:12
@bakpaul
bakpaul force-pushed the framework_warnings_as_errors branch from 030d586 to 54ecd57 Compare November 12, 2026 14:12
@bakpaul bakpaul removed the pr: based on previous PR PR based on a previous PR, therefore to be merged ONLY subsequently label Nov 12, 2026
@bakpaul
bakpaul merged commit 5156bf1 into sofa-framework:master Nov 12, 2026
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean Cleaning the code pr: highlighted in next release Highlight this contribution in the notes of the upcoming release pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants