Repository navigation
spear-image: read labels from the neutral spear.* namespace - #9
Merged
Merged
Conversation
build-tiered.sh writes its labels under spear.* (as push.sh already reads), but spear-image inspect/list still looked only under the old ch.heig-vd.reds.spear.* namespace, so a tiered image showed a blank profile and redistributable, and list did not show it at all. Read spear.* first and fall back to the old namespace, exactly as push.sh does, and union both in list so tiered and legacy images both appear. Update the stale build-needs-a-profile assertion to the current message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #8.
build-tiered.shwrites its image labels under the neutralspear.*namespace (whichpush.shalready reads), butspear-image inspectandliststill looked only under the oldch.heig-vd.reds.spear.*namespace. A tiered image therefore showed a blankprofile/redistributableunderinspect, and did not appear inlistat all.Observed on a freshly built
spear:0.3.0-harness: correctspear.profile=harness/spear.redistributable=truelabels on the image, butspear-image inspect harnessprinted blank fields.Fix
label()readsspear.<key>first and falls back to the old namespace, exactly aspush.shdoes — so tiered and legacy images both read.listunions both namespaces so tiered (spear.profile) and legacy (ch.heig-vd.reds.spear.profile) images both appear.test_build_needs_a_profileassertion to the current build-profile message.Tests
test_spear_imagegreen (was 1 pre-existing failure, now fixed).