Repository navigation
Load standard role profiles from the store, not source - #7
Merged
Merged
Conversation
…urce The harness no longer hardcodes any particular standard. The role taxonomy a standard needs when its labels mean something other than the conventional reading now travels with its data: a profile.json beside the ingested revision in the store, loaded at bind time (StandardOperator._register_profile), so it reaches an image with the document and is never named in this public source. - normative_force.RoleTaxonomy.from_mapping deserializes a stored profile. - standard_profiles.register_for loads it best-effort; a standard with no profile keeps the conventional taxonomy. The hardcoded ANSI-VITA-49.2 taxonomy, which was byte-for-byte the conventional reading, is gone -- no behaviour change. - normative_claims names only the common standards bodies and takes the rest from SPEAR_STANDARD_BODIES, so a deployment adds its own without touching this source. - The test suite binds a neutral EXAMPLE-STD-1.0 example throughout. Full suite green apart from one pre-existing, unrelated failure (test_environment_namespace, about SPEAR_REDS_* shell variables on main).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The harness no longer hardcodes any particular standard. Complements #6 (which genericised docs and comments); together they take the worked example out of the public source entirely while the standard itself stays private, shipped in the store and baked only into private images.
What changed
RoleTaxonomy.from_mappingdeserialises aprofile.jsona standard ships beside its ingested revision in the store;standard_profiles.register_forloads it at bind time (StandardOperator._register_profile), best-effort. A standard with no profile keeps the conventional reading.ANSI-VITA-49.2role taxonomy was byte-for-byte identical toCONVENTIONAL, so removing it changes no behaviour — it just stops naming a standard in public source.normative_claimskeeps only the common bodies and takes the rest fromSPEAR_STANDARD_BODIES, so a deployment adds its own without touching source.EXAMPLE-STD-1.0example throughout (26 files).Validation
Full suite run with the configured venv: 4470 tests, all green except one pre-existing, unrelated failure (
test_environment_namespace, aboutSPEAR_REDS_*shell variables already on main).