Repository navigation
build: keep the base's commons index when a project bakes corpora - #12
Merged
Merged
Conversation
Dockerfile.project COPIES the staged index over the base's chromadb rather than merging into it, so staging only $BAKE left a baked project image with just its own corpora and none of the base's commons -- the reds platform retrieval silently gone. Stage commons + project corpora together so the replacement is the full set the comment already promised, and keep the index empty (base untouched) when nothing is baked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
build-tiered.sh projectstaged its index from$BAKEalone, thenDockerfile.projectCOPIES that index over the base'schromadb/(replace, not merge). So a project built with--bake/SPEAR_BAKEshipped with only its own corpora indexed and lost every commons collection the base carried — the comment already said the staged index was meant to be "the FULL set the base already has plus this project's corpora", but the code didn't build that set.Fix
Stage
commons + project corporatogether, and keep the staged index empty (base left untouched) when nothing is baked:Why it hadn't been hit
The default project build bakes nothing (
spear-privateis mounted at runtime), which already took the empty-index branch and preserved the base. The bug only bites the baked, self-contained path — untested until now.Validation
spear-image build projecton reds: project image carries 14 collections (identical to the base). ✓