Repository navigation
bsp (virt64): expose EL2 on every AVZ machine of a chain without ATF - #72
Open
daniel-rossier wants to merge 1 commit into
Open
daniel-rossier wants to merge 1 commit into
daniel-rossier wants to merge 1 commit into
Conversation
Only the machine reading U-Boot off the card got virtualization=on under AVZ. The one handing U-Boot to QEMU with -kernel, kept for a position-independent U-Boot, was always a plain "virt,gic-version=2", so AVZ would fault on its first EL2 system-register access there. Both now take the machine from __virt64_machine(), as in so3. The deploy comment also says that __deploy_arm_common handles both boot shapes, which it does.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the chains without ATF,
__do_platform_boot_chainbuilds the QEMU machine in two places. Only the boot-ROM one (U-Boot read off the card) addedvirtualization=onunderIB_HYPERVISOR="avz". The-kernel u-boot/u-bootone, kept for a position-independent U-Boot, always wrote a plainvirt,gic-version=2, so AVZ would fault on its first EL2 system-register access there.Both now go through
__virt64_machine(hyp), taken from so3, wherebsp_virt64.incis now byte-identical. The__do_platform_deploycomment also says that__deploy_arm_commonhandles both boot shapes, which it does.The
-kernelpath is latent here: virt64 always buildsvirt64_defconfig, linked at a RAM address, so the card path is the one taken. Tested in so3 (virt64, uboot chain): the same file deploys and boots SO3 with U-Boot from the card.