Skip to content

feat(cli): add --limit to search - #243

Merged
harlan-zw merged 1 commit into
mainfrom
feat/search-limit
Nov 18, 2026
Merged

harlan-zw merged 1 commit into
mainfrom
feat/search-limit

Conversation

@oritwoen

Copy link
Copy Markdown
Collaborator

This adds --limit to skilld search. Twenty descriptions is a lot when an Agent wanted three: vue at --limit 5 measured 1982 bytes of JSON, not 8727.

@oritwoen oritwoen self-assigned this Nov 17, 2026
@harlan-github-agent

harlan-github-agent Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

🤖 MERGED

Harlan Agent Kit posted this automated review. It is not Harlan's personal review or approval. AI open source policy. Last updated: 2026-11-18 08:20 UTC.

GitHub merged this pull request.

  • Logged (35/100): A registry that returns too many results can make the CLI exceed the caller’s output limit. View code Optional follow-up: As an optional follow-up, cap the ranked items at the effective limit before rendering and preserve the registry’s total.
    • Ask an agent to verify and fix this finding
  • Logged (20/100): The new option breaks source compatibility for Rust callers that override Host::search. View code Optional follow-up: As an optional follow-up, preserve the existing trait method and add a defaulted limit-aware method that native hosts can override.
    • Ask an agent to verify and fix this finding

03170109-9040-4d76-ba00-7b6aa0363c0a

Selected findings run after merge and open separate pull requests.

@harlan-zw harlan-zw added the harlan-agent-review Approve automated work for the current issue state or pull request head commit. label Nov 18, 2026
@harlan-github-agent harlan-github-agent Bot added harlan-agent-ready The automated Review passed every gate on this head commit. and removed harlan-agent-review Approve automated work for the current issue state or pull request head commit. labels Nov 18, 2026

@harlan-github-agent harlan-github-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Harlan Agent Kit posted this automated review. AI open source policy.

Automated Review: READY.

Read the Review results

@harlan-zw
harlan-zw merged commit 28b4d51 into main Nov 18, 2026
4 checks passed
@harlan-github-agent harlan-github-agent Bot removed the harlan-agent-ready The automated Review passed every gate on this head commit. label Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants