Repository navigation
fix(deps): key dependency patches by whole major - #707
Merged
Merged
Conversation
A range such as ^2.13.4 still skips an older copy in the same major without a warning, which is the failure #702 fixed. Each patch now covers its whole major, so any copy takes the patch or fails install. The Vitest prefix alias for nitropack/runtime also caught the separate nitropack/runtime/meta export, which then failed to resolve, and a missing nitropack dependency would have fallen back to the hoisted copy without a warning.
Collaborator
Author
|
🤖 Harlan Agent Kit Agent assessment of head ef2e246. The Service Review was stopped for this head because the review engine is down. An independent read-only subagent reviewed the diff. This is not a Service No blocker found (confidence 95/100). It confirmed in a pnpm 12.9.1 scratch project that Logged follow-ups, none above 80:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Follow-up to the logged findings on #702. No GitHub issue.
❓ Type of change
📚 Description
#702 keyed each patch by a caret range such as
nitropack@^2.13.4. pnpm still skips a copy outside that range without a warning, so an older 2.x copy would ship unpatched, which is the failure #702 fixed. Each patch is now keyed by its whole major (hookable@5,hookable@6,nitropack@2): any copy in the major takes the patch, or the install fails.Two gaps in the Vitest alias from #702 are also closed:
nitropack/runtimeprefix alias also caughtnitropack/runtime/meta, a separate export, which then failed to resolve. It now has its own alias.@nuxt/nitro-serverstops depending onnitropack, the config now throws instead of resolving pnpm's hoisted copy, which the build may not bundle.