Repository navigation
fix(checkin): parse Cloudflare analytics failures at the boundary - #706
Merged
Merged
Conversation
The Workers collector parsed JSON before it checked the status, so a proxy error page lost the status. It passed a 200 response whose errors carried no message. The Analytics Engine collector dropped the API's message. Each response is now parsed once into rows or a bounded reason. The operations prompt also says Worker rates use the Workers window, which can be shorter than the baseline gap.
Collaborator
Author
|
Agent check (Harlan Agent Kit), run by hand because CI cannot reach Cloudflare:
|
Collaborator
Author
|
🤖 Harlan Agent Kit Agent assessment of head 1a47935. The Service Review was stopped for this head because the review engine is down. An independent read-only subagent reviewed the diff. This is not a Service No blocker found (confidence 95/100). Logged follow-ups, none above 80:
|
1 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Follow-up to the logged findings on #704. No GitHub issue.
❓ Type of change
📚 Description
The check-in's Cloudflare collectors hid why a read failed:
JSON.parseerror without the status.Each response is now parsed once into its rows or a failure reason (
parseWorkersResponse,parseAnalyticsEngineResponse). The reason keeps the status and the API's message, capped at 300 characters. Theskilld.operationsprompt also says to compute Worker rates overworkers.windowwhen it is clamped, never overgapHours.