Skip to content

perf(home): preserve the hero image during hydration #710

Open

Description

@harlan-github-agent

The carousel shuffles its entire demo order in onMounted while picked remains zero. This can replace the server-rendered opening image during hydration, forcing another image request before the final hero can paint. Latest mobile Scan details identify a carousel screenshot as LCP. Preserve the server-selected opening demo and defer any reordering until navigation. This removes the startup image replacement. Performance action 01M2J4SG3QK0095X6TVB0BP6T9 describes additional blocking CSS, which this focused repair does not claim to remove. Source matches controller deployment commit 48986bf. Complete open ownership bodies contain no matching repair; PR #695's omitted body and closed-fix history remain coverage gaps.

Lab evidence: mobile Poor for the last 2 measured Scans since 2026-11-11T03:39:36.000Z. Latest 4351 ms. Last better Scan: 2026-11-04T03:15:25.000Z. Suspect commits: unavailable: controller deployment history does not cover 2026-11-04T03:15:25.000Z..2026-11-11T03:39:36.000Z.

Lab verification: run Unlighthouse on / with --mobile before and after the fix.

Target: app/pages/_HomeDemoCarousel.vue

Verify with: pnpm dlx unlighthouse-ci --site http://localhost:4173 --urls / --mobile --throttle --samples 3 --reporter jsonExpanded --output-path "$HOME/scratch/vitals-review/hero-hydration/after"

Estimated to change 1 file.

The vitals-review routine opened this issue automatically on its 2026-11-18T01:00:00.000Z run. It is not Harlan's own report. Close it to reject the proposal, and the reason you give stops it being offered again.

Activity

  1. harlan-github-agent commented on Nov 18, 2026

    @harlan-github-agent
    ContributorAuthor

    🤖 ISSUE TRIAGE

    Harlan Agent Kit posted this automated triage. It is not Harlan's personal assessment or commitment. AI open source policy.

    • Route: Ready to implement
    • Difficulty: 2/5
    • Impact: 3/5
    • Reproduction: Yes
    • Codebase review: Not needed
    • Summary: Confirmed: onMounted shuffles every demo while picked stays zero, potentially replacing the eager hero image. Scope is bounded. No matching open repair found; chore(deps): bump the npm_and_yarn group across 1 directory with 15 updates #695 changes dependency files only. Bounded history searches found no matching fi
    • Next action: Implement in app/pages/_HomeDemoCarousel.vue: preserve the server-selected opening demo until navigation, then randomize remaining demos once. Add a failing behavior test for image stability through mount and correct previous/next navigation. Compare mobile Unlighthouse measurements before and after. Keep blocking CSS outside scope.
    • Related pull requests: feat(home): lead with demos and simplify demo handoff #576: Introduced the hero carousel and randomized starting order responsible for the startup replacement.
  2. added
    harlan-agent-ready-to-implementIssue triage found bounded work ready for an implementation Agent.
    harlan-agent-runningAn Agent holds a Task on this issue or pull request right now.
    and removed
    harlan-agent-runningAn Agent holds a Task on this issue or pull request right now.
    on Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions