Repository navigation
Conversation
- The macOS 27 SDK's Foundation declares its own ProgressReporter, so
files importing both Foundation and LibraryStore no longer compile
("'ProgressReporter' is ambiguous for type lookup")
- Qualifying with the module name doesn't work because the module has an
enum of the same name, so add the alias LibraryProgressReporter in
LibraryStore and use it from AppCore, the import CLI and the tests
- The protocol itself is unchanged
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
この PR は、StackNest から qooViewer へ渡した本に qooViewer の機能をより多く使えるようにする拡張(下の「関連する PR」)を作り、測っている途中で気づいた点です。拡張に必須の変更ではありません(拡張はこれ無しでも動きます)。小さな改善として、方針に合えば取り入れていただけるとうれしいです。
問題
macOS 27 SDK(Xcode 27)でビルドすると、Foundation が
ProgressReporterを足したため、LibraryStoreのProgressReporterと名前がぶつかって曖昧になり、ビルドが通りません。モジュール名で修飾しようにも、LibraryStoreという名前の enum があるためLibraryStore.ProgressReporterがそちらに解決されてしまいます。直したこと
LibraryStoreにtypealias LibraryProgressReporter = ProgressReporterを足し、ぶつかる所(書庫の作成・CLI の取り込みと進み具合の表示・その試験 2 つ)をこの名前で書きます。振る舞いは変わりません。試験
swift build・swift testとアプリのビルド・試験が通ることを確かめました(main のままでは通りません)。Xcode 26 系の CI でも、名前の差し替えだけなので影響はないはずです。PDFCoverExtractorTestsの 1 件(0 ページの PDF を PDFKit で書き出す試験)が失敗します。この PR とは無関係で、OS の PDFKit の変化によるものとみています。関連する PR
English summary
Found while building and measuring the qooViewer enhancements; not required by them. An optional small improvement; we would be glad if you could take it. The macOS 27 SDK adds
Foundation.ProgressReporter, which clashes withLibraryStore.ProgressReporter, and module qualification resolves to theLibraryStoreenum. ALibraryProgressReportertypealias is used at the clashing sites; no behaviour change.🤖 Generated with Claude Code