Repository navigation
lib/, src/, tests/: Unname unused parameter in callbacks - #1798
Open
alejandro-colomar wants to merge 2 commits into
Open
alejandro-colomar wants to merge 2 commits into
alejandro-colomar wants to merge 2 commits into
Conversation
This is now always used. Fixes: e6ba8bb (2026-10-20; "newuidmap/newgidmap: Make capability support unconditional") Signed-off-by: Alejandro Colomar <alx@kernel.org>
This requires GCC 11. We already applied this change in 9e711e2 (2025-12-05; "lib/, src/ tests/: Unname unused parameters in callbacks"). Later reverted it in cb0ec03 (2026-03-02; "Fix build failure on hosts with gcc 10"), since Debian Bullseye still had GCC 10. Now Debian Bullseye's LTS period has expired, and the user that reported the problem seems to be okay with bumping the requirement to GCC 11, since they don't need it anymore. Link: <shadow-maint#1531> Cc: Chen Qi <Qi.Chen@windriver.com> Cc: Serge Hallyn <serge@hallyn.com> Signed-off-by: Alejandro Colomar <alx@kernel.org>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumping to GCC 11 would be nice; it's just ~5 years old.
Cc: @ChenQi1989, @hallyn , @ojeda