Repository navigation
passwd: - #1796
Merged
alejandro-colomar merged 2 commits intoNov 11, 2026
Merged
passwd:#1796
passwd:#1796Conversation
alexey-tikhonov
commented
Nov 9, 2026
alexey-tikhonov
marked this pull request as ready for review
November 9, 2026 18:53
alexey-tikhonov
force-pushed
the
passwd-stdin
branch
from
November 11, 2026 09:32
b498b35 to
26f5eb2
Compare
alexey-tikhonov
force-pushed
the
passwd-stdin
branch
from
November 11, 2026 11:20
26f5eb2 to
ffabc38
Compare
Contributor
Author
|
|
to match behavior of `do_pam_passwd()`. Note that change is intentionally done outside of `do_pam_passwd_non_interactive()` because this function is used in other places as well, where logging is undesirde.
With `--stdin`, a failing PAM password change was ignored and `passwd` exited with 0. Changed to exit with `E_PAM_ERR` in this case instead Note: this is potentially breaking for scripts using `passwd --stdin` that assumed a 0 exit status unconditionally.
alexey-tikhonov
force-pushed
the
passwd-stdin
branch
from
November 11, 2026 11:43
ffabc38 to
f84d48a
Compare
alejandro-colomar
approved these changes
Nov 11, 2026
alejandro-colomar
left a comment
alejandro-colomar
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Thanks!
alejandro-colomar
merged commit Nov 11, 2026
01d6341
into
shadow-maint:master
11 of 15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
do_pam_passwd_non_interactive()