Repository navigation
fix(zendesk): count a ticket as unassigned only when Zendesk returns it unassigned - #85
Merged
Merged
Conversation
…it unassigned On a ticket with a live chat open, Zendesk can answer 200 to clearing the assignee and keep it (29557, twice). The digest would then report the chat as released. unassign now reads the assignee off the ticket Zendesk returns, so a kept one is listed for an admin instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #84. On 29557 Zendesk answered 200 to
{"assignee_id": null}twice and kept the assignee, with no audit.api.unassigntreated the 200 as success, so the digest would have said the chat was released.It now reads
assignee_idoff the ticket in the response: anything but an explicitnullcounts as kept, and the ticket goes on the "until an admin unassigns it" line.Tests:
uv run python -m unittest discover -s tests -t .(1010 pass).