Skip to content

Fix VOD playback pausing past the chat's end, and chat dumps ending mid-stream - #9

Merged
second2falcon merged 2 commits into
masterfrom
claude/awesome-ritchie-21izfz
Nov 9, 2026
Merged

second2falcon merged 2 commits into
masterfrom
claude/awesome-ritchie-21izfz

Conversation

@second2falcon

@second2falcon second2falcon commented Nov 9, 2026 •

Copy link
Copy Markdown
Owner

Summary

Two fixes for the same report: a VOD stopped being playable about 2 hours in, and its chat ended 15 minutes before the video.

1. Player paused on every play past the chat's end (twitch-vod-chat submodule)

Updates the twitch-vod-chat submodule to 4e8b349. The chat ticker's end check compared against the chat log's length instead of the video's duration, so once playback passed the end of the chat every play was paused again on the next tick. Details are in second2falcon/twitch-vod-chat#2.

2. Chat dumper ended the dump on any disconnect (twitch-chat-dumper)

ws.onclose finalized the dump and never reconnected. Twitch closes IRC connections now and then (RECONNECT, maintenance, network blips), so the chat file was finished mid-stream while the video kept recording. In the reported stream the capture ran 17:35:53–19:53:26, but the chat dump ended at 19:38:08, with no ad breaks involved.

The dumper now reconnects after 5 seconds unless close() was called, which happens when the server stops it (SIGTERM). Messages keep their offsets from the original dump start. Added tests/reconnect.test.ts with a mocked websocket. Jest passes (6/6) and tsc --noEmit is clean.

Merge order

Merge second2falcon/twitch-vod-chat#2 first, with a merge commit, so 4e8b349 ends up on its default branch. If it gets squashed, the submodule pointer here needs updating before this is merged.

🤖 Generated with Claude Code

https://claude.ai/code/session_014hw7BtW19ArbvUmkvBU5Hq

Playback past the chat log's length (e.g. a 2h chat log on a longer live
capture) was paused again on every tick, and media keys played with the
progress bar frozen.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014hw7BtW19ArbvUmkvBU5Hq
Any close of the Twitch IRC websocket (RECONNECT, maintenance, a network
blip) finalized the chat dump and the dumper never reconnected, so chat
stopped mid-stream while the video kept recording. Reconnect after 5s
unless close() was called to stop the dump.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014hw7BtW19ArbvUmkvBU5Hq
@second2falcon second2falcon changed the title Bump twitch-vod-chat: fix playback pausing past the chat log's length Fix VOD playback pausing past the chat's end, and chat dumps ending mid-stream Nov 9, 2026
@second2falcon
second2falcon merged commit 3c36142 into master Nov 9, 2026
1 check passed
@second2falcon
second2falcon deleted the claude/awesome-ritchie-21izfz branch November 9, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants