Skip to content

1.4.1: say when the game's walks are not the mod's - #4

Merged
jeany55 merged 1 commit into
mainfrom
c7-mods
Nov 9, 2026
Merged

jeany55 merged 1 commit into
mainfrom
c7-mods

Conversation

@jeany55

@jeany55 jeany55 commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

scm-sim's C7 audit, the Walkability row: its game pathing runs scm-sim's engine with the game's own units and data, and said nothing when a mod's data set was in use or the map recorded one. The panel's game section, the details' "The game's walks" and Copy report now carry one sentence: "These were worked out with the game's own units and data, not with ." Passing the set to the engine is the design question the audit left open (said in the code's comment). Tests: the set in use, the set the map records, the game's own, bad JSON. Headless (a stand-in engine service, since the local editor has no engine page): the notice with Cosmonarchy and with a map that records it, none with the game's data. Known: the walked units' names follow the set ("Protoss Scribe" for the vanilla Probe it walks) — the notice says so, the names themselves are a later fix. 36 tests, type-check and build clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_01VEdp4XDzVHzPqjxSfRiuYR

The game's own pathing runs scm-sim's engine, which takes no data set: it
walks StarCraft's own units over StarCraft's terrain rules. On a map made with
a mod's data set the results looked like the mod's, under the mod's unit names.

When the data set in use is not the game's own, or the map records one
(scmjs\dataset.json) while the game's own is in use, the game's section, the
details panel's list of walks and Copy report carry one sentence: "These were
worked out with the game's own units and data, not with <set>." Handing the
set to scm-sim is a design question left open by the C7 audit, so nothing is
passed to it here.

game.ts: modDataSet, modNotice. The panel follows a data set change.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VEdp4XDzVHzPqjxSfRiuYR
@jeany55
jeany55 merged commit 1683786 into main Nov 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant