Repository navigation
A mod is read and named by @scm-js/mod - #8
Merged
Merged
Conversation
…are gone - source.ts opens what was given through the package's readMod; the prober, the root rule, the system-file and game-archive lists and the old opening code are deleted. The editing session, saving and the text folder stay here. - An unedited mod's hash is the package's identity; an edited mod's is made from its lines with the touched members' lines replaced, which is what the page's reader gives the files handed. - The engine is handed every module that has a hash line (a patcher exe's own plugins and libraries too), so the page names the mod as this plugin does. - A text folder keeps a plugin or FireGraft file that sat beside the archive. - The package's 80 sentences have Korean, from the editor's catalogue. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VEdp4WXGmRNueeznohC2C9
…arge mod is shown before it is named - session.ts: the edited mod's hash is the package's identityWith over the members an edit touched. - A mod over 64 MB is described without hashing its files and named when the hash is first asked for; pending hashes go one way, as before the switch. - One map of opened archives is shared by every read, and closing the mod lets them go. - Korean for the package's nine new sentences; an archive that will not open says its reason in Korean. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VEdp4WXGmRNueeznohC2C9
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VEdp4WXGmRNueeznohC2C9
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Mod Editor opened and named a mod with its own code and with
@scm-js/core0.13's copy of the rules. It now takes them from@scm-js/mod1.1.1, the reader the play page, the editor andscmjsuse. The editing session, saving and the text folder stay here.Why
Measured against the package on real mods before the switch:
So a mod opened here could be named differently from the same mod on the play page.
What changed
source.tsopens what was given throughreadMod. The prober, the root rule, the system-file and game-archive lists and the old opening code are deleted.identityWithover the members an edit touched, which equals what the page's reader gives the files handed to it.Checked
npm run typecheckand the tests' own type-check: clean.npm test: 86 passed, 3 skipped (gated).SCMJS_MODS): the hash at open equals the package's pin; the page's reader gives the same hash as the editor before and after an edit.Not checked, not done
dist/plugin.jsgrows from 692 KB to about 786 KB (CI builds it)..dllis taken as a library by the page when handed in game paths.@scm-js/core's range is unchanged.🤖 Generated with Claude Code
https://claude.ai/code/session_01VEdp4WXGmRNueeznohC2C9