Repository navigation
Conversation
Opening C:\Cosmonarchy (the mod's Release/ beside a whole 1.16.1 Starcraft/)
laid the game's own archives as layers of the mod, in the order found, the
later winning: about 1,800 game files, and in Windows' folder order
StarDat.mpq last, so the mod carried original StarCraft's scripts\iscript.bin,
arr\units.dat and arr\images.dat. A replay watched with it stopped on the play
page at "iscript.bin: script 12052 at 167 lacks the SCPE marker".
- A folder that holds a StarDat.mpq is a copy of the game: its StarDat.mpq,
BrooDat.mpq, patch_rt.mpq, StarCraft.mpq and BroodWar.mpq, and everything
under its Maps folder, are left out unread (GAME_ARCHIVES / gameCopyFiles in
source.ts; the same list and function go into @scm-js/core's next release,
the command line and the play page). Anything else in the folder is taken as
before, and one file the person names (an old mod's lone patch_rt.mpq) opens
as it did.
- ModSource.gameCopy names the archives left out; a toast at open, the found
line and Save as Folder's mod.json say so. A map or a campaign's music under
Maps goes to `left`, so it neither sets the mod's root nor counts as a mod.
- A copy of the game with no mod in it (no archive laid, no plugin, no
FireGraft file, no loose file under one of the game's folders) is refused:
"{folder} is a copy of the game, and there is no mod in it."
The real folder (tests/cosmonarchy.test.ts, SCMJS_COSMONARCHY_ROOT): the root
opens as Release does, 7,767 files, 7 plugins, 2 FireGraft files, hash
20e1c6d89ae2af75, with seven archives named as the game's; Starcraft alone is
refused.
0.3.1.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VEdp4UTu4GSxnUBn2BFi6S
Twenty-one strings wrote a particle after the braces, `{file}|은`. The editor
reads it inside them, `{file|은}`, and chooses 은 or 는 by the value's last
syllable; written after, the bar and the particle were shown as typed. All
rewritten, and the catalogue's test refuses the old form.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VEdp4UTu4GSxnUBn2BFi6S
The test the previous commit's message names: no Korean string may hold `}|`, the form the editor shows as typed. The catalogue before that commit fails it on nineteen lines. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VEdp4UTu4GSxnUBn2BFi6S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened
Opening
C:\Cosmonarchy(the mod'sRelease/beside a whole 1.16.1Starcraft/) laid the game's own archives as layers of the mod, in the order found, the later winning: about 1,800 game files, and in Windows' folder orderStarDat.mpqlast. The mod then carried original StarCraft'sscripts\iscript.bin,arr\units.datandarr\images.dat, and a replay watched with it stopped on the play page at "iscript.bin: script 12052 at 167 lacks the SCPE marker".The rule
A folder that holds a
StarDat.mpqis a copy of the game. ItsStarDat.mpq,BrooDat.mpq,patch_rt.mpq,StarCraft.mpqandBroodWar.mpq, and everything under itsMapsfolder, are left out unread. Anything else in the folder is taken as before, and one file the person names (an old mod's lonepatch_rt.mpq) opens as it did. The same rule goes intoscmjs mod/@scm-js/coreand the play page's drop.mod.jsonname the archives left out: "{folder} is a copy of the game. Its own archives ({list}) are not part of the mod and were left out."Checked
npm test,npm run typecheck,npm run buildpass;tests/gamecopy.test.tscovers the rule with made archives.SCMJS_COSMONARCHY_ROOT=/mnt/c/Cosmonarchy): the root opens asReleasedoes (7,767 files, 7 plugins, 2 FireGraft files, hash20e1c6d89ae2af75), with seven archives named as the game's;Starcraftalone is refused.The other two commits
Twenty-one Korean strings wrote a particle after the braces (
{file}|은), which the editor shows as typed; they are now{file|은}, and the catalogue's test refuses the old form.0.3.1.
🤖 Generated with Claude Code
https://claude.ai/code/session_01VEdp4UTu4GSxnUBn2BFi6S