Repository navigation
A replay whose header holds no start time shows no date - #41
Merged
Merged
Conversation
A bot ladder's replays carry the game's seed where the start time goes, so the panel read 12/31/1969 for them. A time before 1998 is not a start time and is left out, the line `scmjs replay info` already draws. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VEdp4VmmNcU4rJMjzWA4pZ
This was referenced Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bot ladder's replays (
scmjs bot ladder,map balance --out) carry the game's seed where a replay's header holds its start time, so the panel's line under the map's name read "Melee · 14:12 · 12/31/1969 · before 1.18". A start time before 1998, when StarCraft came out, is now taken as no start time and the date is left out: "Melee · 14:12 · before 1.18".scmjs replay infoalready draws the same line.playedOninreport.tsdecides it, with a test.tsc -p tsconfig.json: cleanvitest run: 229 passed🤖 Generated with Claude Code
https://claude.ai/code/session_01VEdp4VmmNcU4rJMjzWA4pZ