Skip to content

A replay whose header holds no start time shows no date - #41

Merged
jeany55 merged 1 commit into
mainfrom
ladder-replay-date
Nov 16, 2026
Merged

jeany55 merged 1 commit into
mainfrom
ladder-replay-date

Conversation

@jeany55

@jeany55 jeany55 commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

A bot ladder's replays (scmjs bot ladder, map balance --out) carry the game's seed where a replay's header holds its start time, so the panel's line under the map's name read "Melee · 14:12 · 12/31/1969 · before 1.18". A start time before 1998, when StarCraft came out, is now taken as no start time and the date is left out: "Melee · 14:12 · before 1.18". scmjs replay info already draws the same line.

playedOn in report.ts decides it, with a test.

  • tsc -p tsconfig.json: clean
  • vitest run: 229 passed

🤖 Generated with Claude Code

https://claude.ai/code/session_01VEdp4VmmNcU4rJMjzWA4pZ

A bot ladder's replays carry the game's seed where the start time goes, so
the panel read 12/31/1969 for them. A time before 1998 is not a start time
and is left out, the line `scmjs replay info` already draws.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VEdp4VmmNcU4rJMjzWA4pZ
@jeany55
jeany55 merged commit cbec437 into main Nov 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant