Repository navigation
0.26.0: the Game view steps back for the game's own screen - #39
Merged
Merged
Conversation
For a replay of a mod whose code ran, the play page shows the game's own screen: its console, minimap, tooltips and the mod's own interface, drawn by the game. What the editor and Aftermath put over the game, or do to it, has no meaning there, and is put away while it is on: Orders, Legend and Vision are hidden; the editor's Fog of War is greyed; the tooltip, the pointer's place and the editor's zoom are left alone; the grid, locations and other plugins' overlays are not drawn over it; the cinematic view's own minimap goes. Spectate, play, speed, seeks, the minimap and sounds work as before. The timeline has a switch, "Game's own screen", where the page offers it: off gives the play page's own picture of the map and every control back. With a play page or a scm-sim plugin from before (0.20.1), nothing is said of it and nothing changes. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VEdp4UtqFn9GmthJP21viP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a replay of a mod whose code ran, the play page shows the game's own screen: its console, minimap, tooltips and the mod's own interface, drawn by the game. Aftermath kept its own controls over it, where they do nothing or land in the wrong place.
While the game's own screen is on:
The timeline has a switch, Game's own screen, where the page offers it. Off gives the play page's own picture of the map and every control back.
Needs scm-js/plugin-scm-sim#33 (0.21.0) to see anything. With 0.20.1, or a play page from before, nothing changes: a test runs the new Game view against 0.20.1's bridge.
Checks
Type-check clean; 237 tests pass. In the editor on a local site, headless, with a mod's replay: the controls hidden with the switch pressed, back when it is turned off, hidden again when on; a plain replay's strip unchanged.
Not done: the editor's own zoom figure and its Grid and Locations toggles stay on show (a plugin cannot hide them); the game's own replay panel's pause and speed are not followed by Aftermath's Play button and speed menu; the cinematic view's changes are tested but were not run in a browser.
🤖 Generated with Claude Code
https://claude.ai/code/session_01VEdp4UtqFn9GmthJP21viP