Repository navigation
test: make build_paths state-dir assertion host-independent - #13
Merged
Merged
Conversation
Problem: test_build_paths_uses_var_lib_for_manifest_state failed on macOS. Cause: build_paths() resolves its system roots, and /var is a symlink to /private/var on macOS, so the literal /var/lib path never matched. The product behavior is intentional and consistent; the expectation was host-specific. test_app_registry and test_client_side_timestamp_rendering do not read built assets or host paths and already pass from any cwd. Fix: compare against Path(...).resolve(), keeping the same three assertions. Verified: - test_manage_parseus_lib.py: all pass (was 1 failed) - test_app_registry + test_client_side_timestamp_rendering: 14 passed from /tmp cwd - full suite: only Elasticsearch-server failures remain Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Ethane98
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
test_build_paths_uses_var_lib_for_manifest_statefailed on macOS:build_paths()resolves its system roots, and/varis a symlink to/private/varthere, so the literal/var/libnever matched. The product behaviour is intentional; the expectation was host-specific. The test now compares againstPath(...).resolve()and keeps all three assertions.Related Issues/PRs
Type of Change
fix)feat)docs)refactor)chore)Checklist
Testing
tests/test_manage_parseus_lib.py: all pass on macOS (was 1 failed).test_app_registryandtest_client_side_timestamp_rendering, which had been suspected of depending on built assets, pass from any working directory, so they are unchanged.🤖 Generated with Claude Code