Skip to content

test: make build_paths state-dir assertion host-independent - #13

Merged
adamsrnmsu merged 1 commit into
sandialabs:mainfrom
adamsrnmsu:test-hermetic-env-tests
Nov 19, 2026
Merged

adamsrnmsu merged 1 commit into
sandialabs:mainfrom
adamsrnmsu:test-hermetic-env-tests

Conversation

@adamsrnmsu

Copy link
Copy Markdown
Collaborator

Description

test_build_paths_uses_var_lib_for_manifest_state failed on macOS: build_paths() resolves its system roots, and /var is a symlink to /private/var there, so the literal /var/lib never matched. The product behaviour is intentional; the expectation was host-specific. The test now compares against Path(...).resolve() and keeps all three assertions.

Related Issues/PRs

Type of Change

  • Bugfix (fix)
  • Feature (feat)
  • Documentation (docs)
  • Refactor (refactor)
  • Chore (CI, build, dependencies, etc.) (chore)
  • Other (please describe): test fix

Checklist

Testing

  • tests/test_manage_parseus_lib.py: all pass on macOS (was 1 failed).
  • test_app_registry and test_client_side_timestamp_rendering, which had been suspected of depending on built assets, pass from any working directory, so they are unchanged.
  • Full suite on macOS: only the Elasticsearch-server tests fail now.

🤖 Generated with Claude Code

Problem: test_build_paths_uses_var_lib_for_manifest_state failed on macOS.

Cause: build_paths() resolves its system roots, and /var is a symlink to
/private/var on macOS, so the literal /var/lib path never matched. The
product behavior is intentional and consistent; the expectation was
host-specific. test_app_registry and test_client_side_timestamp_rendering
do not read built assets or host paths and already pass from any cwd.

Fix: compare against Path(...).resolve(), keeping the same three assertions.

Verified:
- test_manage_parseus_lib.py: all pass (was 1 failed)
- test_app_registry + test_client_side_timestamp_rendering: 14 passed from /tmp cwd
- full suite: only Elasticsearch-server failures remain

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@adamsrnmsu
adamsrnmsu merged commit e0992c4 into sandialabs:main Nov 19, 2026
4 checks passed
@adamsrnmsu
adamsrnmsu deleted the test-hermetic-env-tests branch November 19, 2026 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants