Repository navigation
kit-206-viewer-reload-hint: The artifact viewer's reload button shows an orange outline when the artifact changed since it was loaded - #242
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…iew (changes), fixes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The artifact viewer's reload button now says when the artifact on the stage has changed since its frame loaded it. It gets a 2px outline in the warning colour (
--amber, light and dark) and the title "A newer version is ready: reload to see it". Pressing reload loads the new version and clears the outline. Nothing reloads by itself. This holds until kit-106's live reload of drafts takes over./api/datapoll, using the Library's rows for the draft or main shown./api/viewevery 10 s while the tab is visible, for main or a draft only, one ask at a time, with a 15 s abort. A published tree and a preview are never checked.TS.fpstays the fingerprint the frame loaded.TS.fpNowandTS.mainFpNowhold the latest seen. Reload movesfpandmainFpforward, and only to values it knows.Records:
docs/devteam-dev/tickets/kit-206-viewer-reload-hint/(spec, plan, reviews, verification, and screenshots in light and dark).How to verify
node --test --test-name-pattern "reload button says" test/dashboard.test.mjs(needs Chrome and a Node with WebSocket, 22+). It opens a draft on the dashboard and in a viewer tab, changes the file, and waits for the outline within one poll. It checks the colour in light and dark, checks that nothing reloads by itself, and checks that the press loads the change. It also checks that a tree is never polled.One-way doors
None.
🤖 Generated with Claude Code