Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Barstool redacts Authorization and Set-Cookie already, but the stored URL kept the raw query string. Requests that interact with APIs that require auth via a query param such as
?access_token=secret&api_key=secretwas written in full on the request, the response, and a connection error. Yes, services shouldn't have such poor security 😆Credential query values are now replaced with
REDACTEDbefore the URL is stored. Matching ignores case, soAPI_KEYis covered as well asapi_key. Ordinary parameters such asaccount_idare kept. User info in the URL (user:password@host) is stored asREDACTED:REDACTED. The outgoing request is left unchanged.The default names are
access_token,api_key,api-key,apikey,client_secret,id_token,password,refresh_token,secret,sig,signature, andtoken.excluded_query_parametersreplaces that list, and*redacts every query value. Installs that have not published the new config key still use the default list.