Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Barstool queues the request and the response as two separate jobs. This means that if the response job runs first, it cannot find the request row, so it releases itself for 2 seconds.
Laravel counts that release as an attempt, and the job only has 3 tries. On the fourth pickup the worker fails the job before
handle()runs. The request row can still be written later, with no status, body, or duration. A fatal recording uses the same path.A response or fatal job now gets a 10 minute
retryUntil()deadline, which Laravel honours ahead of the 3 try limit. While the request row is missing, the job waits using the configured backoff (5 seconds, then 30) instead of releasing every 2 seconds. Request jobs still stop after 3 tries.