Repository navigation
Keep time of day and offset in Time.strptime with ISO week dates #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
0z5a
wants to merge
1
commit into
ruby:master
Choose a base branch
from
0z5a:fix/strptime-week-date-time
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing
ydaysends these throughmake_time's yday branch, which gets the day wrong for late times with a negative offset. It guessesmon, day = (yday-1).divmod(31)(e.g. Feb 29/31), andapply_offseton that invalid date moves it by a day or more:Before this PR the date part of these was right (only the time was lost), so it's a regression for them. In a 40k random check against
DateTime.strptime(%G-W%V-%u,%g %V %u,%u %U %Ywith times and offsets) 55 came out on the wrong day, same count with TZ=UTC, America/New_York and Australia/Lord_Howe.Since
d2already has the month and day, passing those avoids the yday guess. With this, the same check has 0 mismatches and the 54 tests pass:(The
%jpath has the same problem on master, e.g.Time.strptime("1985-062 14:58:14 -1130", "%Y-%j %H:%M:%S %z")gives Mar 6. That's separate from this PR; I'll send a fix formake_timeon its own.)