Repository navigation
Run the RFC 8785 number tests on JRuby 10.1.3 and later - #1128
Merged
Merged
Conversation
The RFC 8785 number formatter uses Float#to_s, so these tests were skipped on every engine but CRuby. JRuby 10.1.3 gives the shortest round-trip digits in Float#to_s (jruby/jruby#9916), and all 26 tests pass there. Older JRuby versions print the smallest subnormal as 4.9e-324, so they still skip them. Part of ruby#1123
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RFC 8785 number formatter uses
Float#to_s, so the 26test_rfc8785_number_*tests were skipped on every engine but CRuby.JRuby 10.1.3 gives the shortest round-trip digits in
Float#to_s(jruby/jruby#9916), and all of these tests pass there. Older JRuby versions print the smallest subnormal as4.9e-324instead of5e-324, so they still skip them.